Actually, they both are correct:
default:
if (tr->allocated_snapshot) {
if (iter->cpu_file == RING_BUFFER_ALL_CPUS)
tracing_reset_online_cpus(&tr->max_buffer);
else
tracing_reset(&tr->max_buffer, iter->cpu_file);
}
break;
}
It does nothing if it isn't allocated.
Perhaps we need it to say "(but does not allocate or free)"
-- Steve
Signed-off-by: Wang YanQing <[email protected]>
---
I think "Clears and frees" are reasonable, and
"Clears and allocates are not so reasonable, so
we don't need to say not allocate. But it is help
information, so make it more clearer is also acceptable. :)
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 7974ba2..d5f7c4d 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2760,7 +2760,7 @@ static void show_snapshot_main_help(struct seq_file *m)
seq_printf(m, "# echo 0 > snapshot : Clears and frees snapshot
buffer\n");
seq_printf(m, "# echo 1 > snapshot : Allocates snapshot buffer, if not
already allocated.\n");
seq_printf(m, "# Takes a snapshot of the main
buffer.\n");
- seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does
not allocate)\n");
+ seq_printf(m, "# echo 2 > snapshot : Clears snapshot buffer (but does
not allocate or free)\n");
seq_printf(m, "# (Doesn't have to be '2' works
with any number that\n");
seq_printf(m, "# is not a '0' or '1')\n");
}
--
1.7.12.4.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
