On Sat, Sep 14, 2013 at 8:39 AM, Vladimir Davydov <vdavy...@parallels.com> wrote: > Patch a003a2 (sched: Consider runnable load average in move_tasks()) > sets all top-level cfs_rqs' h_load to rq->avg.load_avg_contrib, which is > always 0. This mistype leads to all tasks having weight 0 when load > balancing in a cpu-cgroup enabled setup. There obviously should be sum > of weights of all runnable tasks there instead. Fix it. >
load_avg_contrib is the weight that > Signed-off-by: Vladimir Davydov <vdavy...@parallels.com> > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 9b3fe1c..13abc29 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4242,7 +4242,7 @@ static void update_cfs_rq_h_load(struct cfs_rq *cfs_rq) > } Once we'v Once we've made it that e made it that > > if (!se) { > - cfs_rq->h_load = rq->avg.load_avg_contrib; > + cfs_rq->h_load = cfs_rq->runnable_load_avg; Looks good. Reviewed-by: Paul Turner <p...@google.com> > cfs_rq->last_h_load_update = now; > } > > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/