On 09/15/2013 06:35 AM, Andrew Morton wrote: > On Sun, 15 Sep 2013 01:27:03 -0300 Thiago Farina <tfrans...@gmail.com> wrote: > >> On Fri, Sep 13, 2013 at 2:37 PM, Andre Naujoks <nauts...@gmail.com> wrote: >>> To be able to use the hex ascii functions in case sensitive environments >>> the array hex_asc_upper[] and the needed functions for hex_byte_pack_upper() >>> are introduced. >>> >>> Signed-off-by: Andre Naujoks <nauts...@gmail.com> >>> --- >>> include/linux/kernel.h | 11 +++++++++++ >>> lib/hexdump.c | 2 ++ >>> 2 files changed, 13 insertions(+) >>> >>> diff --git a/include/linux/kernel.h b/include/linux/kernel.h >>> index 482ad2d..672ddc4 100644 >>> --- a/include/linux/kernel.h >>> +++ b/include/linux/kernel.h >>> @@ -439,6 +439,17 @@ static inline char *hex_byte_pack(char *buf, u8 byte) >>> return buf; >>> } >>> >>> +extern const char hex_asc_upper[]; >>> +#define hex_asc_upper_lo(x) hex_asc_upper[((x) & 0x0f)] >>> +#define hex_asc_upper_hi(x) hex_asc_upper[((x) & 0xf0) >> 4] >> Does using a macro instead of a real function (static inline) >> generates a better code? > > Yes, a static inline would be nicer, but these are derived from > hex_asc_lo/hex_asc_hi. If we change one we should change the other > and that becomes a separate cleanup. So I think this patch is > OK as-is.
Is this an Acked-by? > Also, it would make sense to get all the *hex* stuff out of kernel.h > and into a new header file (hexchar.h?). They're a clean > self-contained thing and kernel.h is rather a dumping ground. Who is taking this series? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
