On Tue, 24 Sep 2013, Ingo Molnar wrote: > During past review of your series Peter Zijlstra very explicitly told you > to reuse (and unify with) the preempt checks in lib/smp_processor_id.c! > See debug_smp_processor_id().
No he did not. He mentioned something about debug_smp_processor_id() at the end of a post after talking about something else. Given your comments now I see what was meant. That was not really obvious in the first place. > The problem isn't just that you are duplicating code and adding > unnecessary #ifdefs into the wrong place, the bigger problem is that you > are implementing weak checks which creates unnecessary raw_*() pollution > all across the kernel. what kind of idiotic comment is that? I am using a single function preemptible(). How is that duplicating anything? > Your lack of cooperation is getting ridiculous! And this kind of insulting behavior is really discouraging people to do work on the kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/