On Fri, Sep 27 2013, Jens Axboe wrote: > On 09/27/2013 05:26 AM, Akhil Bhansali wrote: > > Hello Jens, > > > > There are few improvements suggested by community for driver: > > 1. Replacement of custom macros for debug printing. (DPRINTK / VPRINTK). > > 2. Reformatting of "skd_request_fn" which is too long. > > > > Kindly let us know if you see any other changes required before it can be > > moved to mainline kernel. > > Did you forget to attach the patch?
Sorry, I misread that initially. The major eye sore right now is the PRINTK stuff. The refactor of the request_fn would be a plus. Start with those two, and I'll take a look and see if we need to do more right now. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
