Am Mittwoch, 2. Oktober 2013, 00:57:33 schrieb Jason Gunthorpe: > > When compiling the tpm drivers as modules I get > > ERROR: "tpm_sysfs_del_device" [drivers/char/tpm/tpm.ko] undefined! > > ERROR: "tpm_dev_add_device" [drivers/char/tpm/tpm.ko] undefined! > > ERROR: "tpm_dev_del_device" [drivers/char/tpm/tpm.ko] undefined! > > ERROR: "tpm_sysfs_add_device" [drivers/char/tpm/tpm.ko] undefined! > > ERROR: "tpm_transmit" [drivers/char/tpm/tpm-sysfs.ko] undefined! > > ERROR: "tpm_pcr_read_dev" [drivers/char/tpm/tpm-sysfs.ko] undefined! > > ERROR: "tpm_getcap" [drivers/char/tpm/tpm-sysfs.ko] undefined! > > ERROR: "tpm_transmit" [drivers/char/tpm/tpm-dev.ko] undefined! > > Oh, I am glad you can test modules.. > > I botched the makefile changes for the new .c files. > > I believe it should be like this: > > obj-$(CONFIG_TCG_TPM) += tpm-core.o > tpm-core-y := tpm.o tpm-dev.o tpm-sysfs.o > > > I added a suitable patch with the appropriate EXPORT_SYMBOL_GPL > > declarations to my testing branch. (also see next message) > > EXPORT_SYMBOL_GPL is not correct, these are in-module references, not > cross module references, and I've deliberately not exported them to > prevent drivers from trying to use them inappropriately. Of course you're right - I just wanted to get it compile as fast as possible ;)
The makefile patch did fix it. Staged here https://github.com/PeterHuewe/linux-tpmdd/tree/testing-and-review (along with a small fix for the tpm_i2c_atmel driver ;) Thanks, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
