On 10/03/2013 04:57 PM, Sangjung Woo wrote: > The second parameter of dev_set_name() is format string. In order to > avoid any potential accidents such as segmentation fault, basic format > parameter "%s" should be used in this case.
Since "iio_evgen" is a constant string there is really no need for this. > > Signed-off-by: Sangjung Woo <sangjung....@samsung.com> > --- > drivers/staging/iio/iio_dummy_evgen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/iio_dummy_evgen.c > b/drivers/staging/iio/iio_dummy_evgen.c > index 132d278..2c06d16 100644 > --- a/drivers/staging/iio/iio_dummy_evgen.c > +++ b/drivers/staging/iio/iio_dummy_evgen.c > @@ -205,7 +205,7 @@ static __init int iio_dummy_evgen_init(void) > if (ret < 0) > return ret; > device_initialize(&iio_evgen_dev); > - dev_set_name(&iio_evgen_dev, "iio_evgen"); > + dev_set_name(&iio_evgen_dev, "%s", "iio_evgen"); > return device_add(&iio_evgen_dev); > } > module_init(iio_dummy_evgen_init); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
