Am 03.10.2013 um 22:00 schrieb David Miller: > From: "Dr. H. Nikolaus Schaller" <h...@goldelico.com> > Date: Thu, 3 Oct 2013 21:40:34 +0200 > >> I have made the bug observation from debug log that this bit is set in a >> response >> each time the modem has a RING message. It might be specific to this modem >> and firmware version, i.e. a firmware bug. But we have no means to verify or >> even >> change it in the firmware. >> >> I.e. the driver must handle it in a better way. >> >> Because the notification is rejected by the driver, the driver will hang up >> and the >> whole modem connection breaks down. >> >> With this patch, the problem was never observed again in ~2 years. >> >> I'd hope the maintainer of this driver can shed some light on it. > > I think if you suspect the bit is set in response to RING messages > then you should define a macro so that the number is not just magic, > and put a descriptrive comment above the macro definition for that > bit.
Good idea! I will resend the patch. --- hns-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
