On Wed, Sep 04, 2013 at 09:45:29AM -0700, H. Peter Anvin wrote: [snip] > This also exposes an interesting problem with Fengguang's build robot. > > One build: > [tip:x86/asmlinkage] 28596b6a8779b736829ad837f95fdc2e81bdd1ee BUILD DONE > 28596b6a8779b736829ad837f95fdc2e81bdd1ee x86, asmlinkage, vdso: Mark > vdso variables __visible > > ... flags the warnings. The next build for the branch looks clean: > [tip:x86/asmlinkage] eb86b5fd505cb97743d84226140cf247d91a2f03 BUILD SUCCESS > eb86b5fd505cb97743d84226140cf247d91a2f03 x86/asmlinkage: Fix warning in > xen asmlinkage change > > ("DONE" means warnings or errors.) > > A human observer would assume that the problem was fixed, since the > patch says "fix warnings", but the problem is that it didn't actually > fix *all* the warnings. However, the bot has flagged the warnings as > preexisting from the previous build, and thus no new warnings were > introduced.
Yeah sorry! The build robot silently ignored any reported errors, which is not the expected behavior when sending BUILD SUCCESS notifications. > It would be better if the bot reported any warnings not present in upstream. I've fixed the robot to remember which tree/branch first introduced the build error/warning. If the problem still remains in that branch's new HEAD, the robot will be able to send out BUILD DONE reports which will include the old error/warning message in the email body. Sorry for the delay! This feature was added shortly after your report, however took long time to confirm that it actually works. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/