On 04-10-2013 14:22, Eduardo Valentin wrote: > On 04-10-2013 08:35, Bartlomiej Zolnierkiewicz wrote: >> Menu for Texas Instruments thermal support is visible on all >> platforms and TI_SOC_THERMAL + TI_THERMAL config options can >> be selected also on EXYNOS platform (on which ARCH_HAS_BANDGAP >> config option is selected by SoCs config options to fulfill >> EXYNOS_THERMAL config option dependency). Thus the code which >> is never used can be build. Fix it by making TI menu dependent >> on ARCH_OMAP2PLUS config option. >>
Besides, you can always disable the driver if you are not interested in compiling it. >> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> >> --- >> drivers/thermal/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index 57e06a9..a709c63 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -193,6 +193,7 @@ config X86_PKG_TEMP_THERMAL >> notification methods. >> >> menu "Texas Instruments thermal drivers" >> +depends on ARCH_OMAP2PLUS > > No, this driver is not for ARCH_OMAP*, but for TI bandgap, with the > option to offer thermal control. So, the HW supported is TI bandgap IP, > not ARCH_OMAP*. It happens to be so that OMAP2PLUS all have a > (different) version of this device. > > However, DRA7 devices, for instance, also feature the bandgap IP > (different version of those present in OMAP devices), and it is not > ARCH_OMAP2PLUS. > > And because of that, the design of this driver is different. It is not > expected to depend on an arch, but the arch code is expected to select > ARCH_HAS_BANDGAP. > >> source "drivers/thermal/ti-soc-thermal/Kconfig" >> endmenu >> >> > > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
signature.asc
Description: OpenPGP digital signature