On Sun, Oct 06, 2013 at 12:53:22PM -0700, Joe Perches wrote: > On Sun, 2013-10-06 at 13:38 -0600, Jason Gunthorpe wrote: > > This is preparation for making the tpm module multi-file. kbuild does > > not like having a .c file with the same name as a module. We wish to > > keep the tpm module name so that userspace doesn't see this change. > > If that's true, and I don't believe it is, > then Kbuild should be fixed instead. > > There are a lot of examples of .c files named > the same as the directory they reside in.
That isn't the trouble, it is having a module named tpm, comprised of tpm.c, tpm-foo.c, and tpm-bar.c The issue is that assembling the tpm module uses tpm.o as an intermediate file, and compiling tmp.c uses tpm.o as a intermediate file - they conflict, things don't work right and make throws a circular dependency warning. The Makefile I started with looks like this: obj-m += tpm.o tpm-y := tpm.o tpm-foo.o tpm-bar.o Is there some other solution? In any event, this patch is part of a series that splits tpm.c up, renaming it at this point in the series is to make kbuild work, but at the end of the series it should be renamed anyhow :) Regards, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
