Hi Mark, Thanks for the replies. Please have a look at v9.
On 7 August 2013 17:13, Mark Rutland <[email protected]> wrote: >> + >> + ret = devm_request_irq(dev, irq, moxart_dma_interrupt, 0, >> + "moxart-dma-engine", mdc); >> + if (ret) { >> + dev_err(dev, "devm_request_irq failed\n"); > > Do you not need calls to of_dma_controller_free and > dma_async_device_unregister here? I'm not all that familiar with the DMA > API, so maybe you don't. Yes. I see now, I should have moved both dma_async_device_register() and of_dma_controller_register() to happen after devm_request_irq(). I'll include that in next version. >> +static int moxart_remove(struct platform_device *pdev) >> +{ >> + struct moxart_dma_container *m = dev_get_drvdata(&pdev->dev); > > Similarly, do you not need to call of_dma_controller free here? Yes, this is now done. Best regards, Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
