On Tue, 2013-10-08 at 12:31 -0700, Sukadev Bhattiprolu wrote: > Michael Ellerman [[email protected]] wrote: > | bool is_load_store(int ext_opcode) > | { > | upper = ext_opcode >> 5; > | lower = ext_opcode & 0x1f; > | > | /* Short circuit as many misses as we can */ > | if (lower < 3 || lower > 23) > | return false; > > I see some loads/stores like these which are not covered by > the above check. Is it ok to ignore them ? > > lower == 29: ldepx, stdepx, eviddepx, evstddepx > > lower == 31: lwepx, lbepx, lfdepx, stfdepx,
Those are the external process ID instructions, which I've never heard of anyone using, I think we can ignore them. > Looking through the opcode maps, I also see these for primary > op code 4: > > evldd, evlddx, evldwx, evldw, evldh, evldhx. > > Should we include those also ? Yes I think so. I didn't check any of the other opcodes for you. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

