* Oleg Nesterov <[email protected]> [2013-10-13 21:18:35]: > No functional changes, preparation. > > Extract the code which actually allocates/installs the new area > into the new helper, __create_xol_area(). > > While at it remove the unnecessary "ret = ENOMEM" and "ret = 0" > in xol_add_vma(), they both have no effect. > > Cc: [email protected] # 3.9+ > Signed-off-by: Oleg Nesterov <[email protected]>
Acked-by: Srikar Dronamraju <[email protected]> One nit below. > > /* Slot allocation for XOL */ > -static int xol_add_vma(struct xol_area *area) > +static int xol_add_vma(struct mm_struct *mm, struct xol_area *area) > { > - struct mm_struct *mm = current->mm; > int ret = -EALREADY; > > down_write(&mm->mmap_sem); > if (mm->uprobes_state.xol_area) > goto fail; > > - ret = -ENOMEM; > - /* Try to map as high as possible, this is only a hint. */ > + /* Try to map as high as possible, this is only a hint. */ Nit: This comment seems to be shifted unnecessarily. -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
