On 11:55 Wed 23 Oct , Johan Hovold wrote: > The driver supports 16-bit brightness values, but the value returned > from get_brightness was truncated to eight bits. > > Cc: sta...@vger.kernel.org > Acked-by: Jingoo Han <jg1....@samsung.com> > Signed-off-by: Johan Hovold <jhov...@gmail.com> > --- > drivers/video/backlight/atmel-pwm-bl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/atmel-pwm-bl.c > b/drivers/video/backlight/atmel-pwm-bl.c > index 66885fb..8aac273 100644 > --- a/drivers/video/backlight/atmel-pwm-bl.c > +++ b/drivers/video/backlight/atmel-pwm-bl.c > @@ -70,7 +70,7 @@ static int atmel_pwm_bl_set_intensity(struct > backlight_device *bd) > static int atmel_pwm_bl_get_intensity(struct backlight_device *bd) > { > struct atmel_pwm_bl *pwmbl = bl_get_data(bd); > - u8 intensity; > + u32 intensity; > > if (pwmbl->pdata->pwm_active_low) { > intensity = pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY) - > @@ -80,7 +80,7 @@ static int atmel_pwm_bl_get_intensity(struct > backlight_device *bd) > pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY); > } > > - return intensity; > + return (u16)intensity; no cast mask it > } > > static int atmel_pwm_bl_init_pwm(struct atmel_pwm_bl *pwmbl) > -- > 1.8.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/9] backlight: atmel-pwm-bl: fix reported brightness
Jean-Christophe PLAGNIOL-VILLARD Fri, 25 Oct 2013 04:16:27 -0700
- [PATCH RESEND 0/9] backlight: atmel-pwm-b... Johan Hovold
- [PATCH 1/9] backlight: atmel-pwm-bl:... Johan Hovold
- Re: [PATCH 1/9] backlight: atmel... Jean-Christophe PLAGNIOL-VILLARD
- Re: [PATCH 1/9] backlight: a... Johan Hovold
- [PATCH 7/9] backlight: atmel-pwm-bl:... Johan Hovold
- [PATCH 6/9] backlight: atmel-pwm-bl:... Johan Hovold
- [PATCH 5/9] backlight: atmel-pwm-bl:... Johan Hovold
- Re: [PATCH 5/9] backlight: atmel... Jean-Christophe PLAGNIOL-VILLARD
- [PATCH 4/9] backlight: atmel-pwm-bl:... Johan Hovold
- Re: [PATCH 4/9] backlight: atmel... Jean-Christophe PLAGNIOL-VILLARD
- Re: [PATCH 4/9] backlight: a... Johan Hovold
- [PATCH 8/9] backlight: atmel-pwm-bl:... Johan Hovold
- Re: [PATCH 8/9] backlight: atmel... Jean-Christophe PLAGNIOL-VILLARD