On Fri, 2013-10-25 at 12:24 +0100, Jens Axboe wrote: > On Thu, Oct 24 2013, Joe Perches wrote: > > On Thu, 2013-10-24 at 12:53 +0100, Jens Axboe wrote: > > > On Thu, Oct 24 2013, Ramprasad Chinthekindi wrote: > > > > Hi Jens, > > > > > > > > I'm resending the patch to replace custom debug macros with > > > > pr_debug(). Kindly please review and apply the patch. Thanking you. > > > > > > Thanks, that's a nice improvement. Applied. > > > > Is it really much of an improvement? > > > > It leaves possible different behavior with > > skdev->dbg_level/skd_dbg_level set without > > linkage to a few printks now. > > > > It also doesn't make use of dynamic debug's > > +f/+l capability to and always emits > > __func__/__LINE__. > > It's an improvement from a private FOOPRINTK() macro. Feel free to send > in further improvements.
I already sent what I think appropriate. https://lkml.org/lkml/2013/10/1/324 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
