Vincent, On Tue, 29 Oct 2013, Vincent Donnefort wrote:
Subject line : irqchip: aramda370-xp: fix compilation warning We are not fixing compilation warnings. We modify the code so the compiler does not longer issue a warning. > From: Vincent Donnefort <[email protected]> > > Fix the following compilation warning: > drivers/irqchip/irq-armada-370-xp.c:55:23: warning: 'irq_controller_lock' > defined but not used [-Wunused-variable] > > Signed-off-by: Vincent Donnefort <[email protected]> > > diff --git a/drivers/irqchip/irq-armada-370-xp.c > b/drivers/irqchip/irq-armada-370-xp.c > index bb328a3..75c3141 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -52,7 +52,9 @@ > #define IPI_DOORBELL_END (8) > #define IPI_DOORBELL_MASK 0xFF > > +#ifdef CONFIG_SMP > static DEFINE_RAW_SPINLOCK(irq_controller_lock); > +#endif Instead of adding a new ifdeffery you should just move it into the existing #ifdef CONFIG_SMP section, which also contains the only usage site of irq_controller_lock Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
