Hi Joe,
On 10/29/2013 11:19 AM, Joe Perches wrote:
On Tue, 2013-10-29 at 11:05 -0700, David Cohen wrote:
This patch adds driver for ssp spi interface on Intel Mid platform.
A few simple notes:
Please consider using checkpatch.
I did and got no warnings. But haven't used --strict option.
---
drivers/spi/Kconfig | 12 +
drivers/spi/Makefile | 1 +
drivers/spi/spi-intel-mid-ssp.c | 1506 +++++++++++++++++++++++++++++++++
include/linux/spi/intel_mid_ssp_spi.h | 330 ++++++++
Shouldn't this include file be in the drivers/spi directory?
I can't be. This header file will be needed by Intel MID platform code
located under arch/x86/platform/intel-mid/ directory.
[]
diff --git a/drivers/spi/spi-intel-mid-ssp.c b/drivers/spi/spi-intel-mid-ssp.c
[]
+#ifdef DUMP_RX
+static void dump_trailer(const struct device *dev, char *buf, int len, int sz)
+{
You could save a couple of later #ifdefs by
moving the #ifdef inside the function
I can do that.
static void dump_trailer(etc)
{
#ifdef DUMP_RX
...
#endif
}
+static int map_dma_buffers(struct ssp_drv_context *sspc)
+{
[]
+#ifdef DUMP_RX
+ dump_trailer(&sspc->pdev->dev, sspc->tx, sspc->len, 16);
+#endif
+static void int_transfer_complete(struct ssp_drv_context *sspc)
+{
[]
+#ifdef DUMP_RX
+ dump_trailer(dev, sspc->rx, sspc->len, 16);
+#endif
+static int setup(struct spi_device *spi)
+{
[]
+ if (!chip) {
+ chip = kzalloc(sizeof(struct chip_data), GFP_KERNEL);
+ if (!chip) {
+ dev_err(&spi->dev,
+ "failed setup: can't allocate chip data\n");
OOM messages aren't necessary as a generic OOM message
is already emitted along with a dump_stack();
So I'll remove the message.
Thanks for your feedback. A new version is coming soon.
Br, David Cohen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
