Hi, Philippe

On Thu, Oct 31, 2013 at 08:54:12AM +0100, Philippe Rétornaz wrote:
> Hi
> 
> >
> >+                    /* When using dual fifo mode, we need to keep watermark
> >+                     * as even numbers due to dma script limitation.
> >+                     */
> >+                    ssi_private->dma_params_tx.maxburst /= 2;
> >+                    ssi_private->dma_params_tx.maxburst *= 2;
> >+                    ssi_private->dma_params_rx.maxburst /= 2;
> >+                    ssi_private->dma_params_rx.maxburst *= 2;
> >
> 
> Why not using a mask here ?
> ssi_private->dma_params_tx.maxburst &= ~0x1;
> ssi_private->dma_params_rx.maxburst &= ~0x1;

I'll use this in v3. Thank you!

Nicolin Chen

> 
> Regards,
> 
> Philippe
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to