On Wed, Nov 06, 2013 at 04:45:30PM +0000, Steven Rostedt wrote: > On Wed, 30 Oct 2013 00:48:40 +0000 > Will Deacon <[email protected]> wrote: > > > > > +} > > > + > > > +static __always_inline u32 aarch64_insn_gen_nop(void) > > > +{ > > > + return aarch64_insn_gen_hint(AARCH64_INSN_HINT_NOP); > > > +} > > > > Either use plain old `inline' or write these as preprocessor macros. > > > > I'm curious to why you say that? Preprocessor macros are rather ugly, > and in x86 we use "__always_inline" quite liberally.
I can understand why you might use __always_inline over the preprocessor when you *really* need something inlined, but in this case I don't see why `inline' isn't sufficient. It's just a cosmetic issue, really. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
