On Fri 08-11-13 00:46:49, Frederic Weisbecker wrote:
> On Thu, Nov 07, 2013 at 06:37:17PM -0500, Steven Rostedt wrote:
> > On Fri, 8 Nov 2013 00:21:51 +0100
> > Frederic Weisbecker <[email protected]> wrote:
> > >
> > > Offloading to a workqueue would be perhaps better, and writing to the
> > > serial
> > > console could then be done with interrupts enabled, preemptible context,
> > > etc...
> >
> > Oh God no ;-) Adding workqueue logic into printk just spells a
> > nightmare of much more complexity for a critical kernel infrastructure.
>
> But yeah that's scary, that means workqueues itself can't printk that safely.
> So, you're right after all.
Yeah, we've been there (that was actually my initial proposal). But
Andrew and Steven (rightfully) objected and suggested irq_work should be
used instead.
Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
