From: Cai Zhiyong <caizhiy...@huawei.com> Date: Mon, 11 Nov 2013 19:26:14 +0800 Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value
- Fix 'ret' would return an uninitialized value. - Add a warning avoid invalid 'num_regs' value passed in. When the num_regs parameter is zero and krealloc doesn't fail, then the code would return an uninitialized value. However, calling this function with num_regs == 0, would be a waste as it essentially does nothing. Signed-off-by: Cai Zhiyong <caizhiy...@huawei.com> --- drivers/base/regmap/regmap.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 9c021d9..7b5c28a 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -2170,9 +2170,15 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs, int num_regs) { struct reg_default *p; - int i, ret; + int i; + int ret = 0; bool bypass; + if (num_regs <= 0) { + WARN_ONCE(1, "Call regmap_register_patch with num_regs <= 0."); + return 0; + } + map->lock(map->lock_arg); bypass = map->cache_bypass; -- 1.8.1.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/