* Christoph Hellwig <[email protected]> wrote:
> On Tue, Nov 12, 2013 at 02:13:37PM -0800, David Cohen wrote:
>
> > Hi,
> >
> > This patchset extends sfi_device() macro support to driver modules.
> > The main use case is to allow external driver modules to be enumerated
> > by SFI on Intel Mid platforms.
>
> How about you merge those module again? Remember code added to the
> kernel without users isn't testable, and out of tree modules do not
> bring us any value add.
I wanted to make the exact same point.
I recently had to revert a similarly misguided attempt which added bloat
for out of tree modules without merging it in tree, see commit
b5dfcb09debc ("Revert "x86/UV: Add uvtrace support").
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
