On Thu, 14 Nov 2013, Naoya Horiguchi wrote:
> Introduces a cosmetic substitution of the returned value of
> isolate_huge_page()
> to suppress a build warning when !CONFIG_HUGETLBFS. No behavioral change.
>
> Reported-by: Borislav Petkov <[email protected]>
> Tested-by: Borislav Petkov <[email protected]>
> Signed-off-by: Naoya Horiguchi <[email protected]>
> ---
> mm/migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 4cd63c2..4a26042 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1168,7 +1168,7 @@ static int do_move_page_to_node_array(struct mm_struct
> *mm,
> goto put_and_set;
>
> if (PageHuge(page)) {
> - isolate_huge_page(page, &pagelist);
> + err = isolate_huge_page(page, &pagelist);
> goto put_and_set;
> }
>
I think it would be better to just fix hugetlb.h to do
static inline bool isolate_huge_page(struct page *page, struct
list_head *list)
{
return false;
}
for the !CONFIG_HUGETLB_PAGE variant.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
