On Sun, 2013-11-17 at 09:17 +0000, David Howells wrote: > Mimi Zohar <[email protected]> wrote: > > > + keyctl control <keyid> encrypted change-master-key \ > > + "update key-type:master-key-name" > > Why include the word "update" in the argument? Isn't that implicit in the > command name?
Agreed, it's redundant. encrypted_control() currently strips off the "encrypted change-master-key" string and then calls datablob_parse(), which still expects a key_cmd (eg. new, load, or update). Instead, we could pass "change-master-key" to datablob_parse() as the key_cmd and make the necessary changes. thanks, Mimi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
