I think we're lacking of a commit message here. What does it do? Why do we need it? What would happen if we didn't have it? Why does it differ between revs? Etc etc ... ?
> Signed-off-by: Charles Keepax <[email protected]> > --- > drivers/mfd/wm5110-tables.c | 30 +++++++++++++++++++++++++++++- > 1 files changed, 29 insertions(+), 1 deletions(-) > > diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c > index daf2fe8..bd9c3c9 100644 > --- a/drivers/mfd/wm5110-tables.c > +++ b/drivers/mfd/wm5110-tables.c > @@ -223,6 +223,31 @@ static const struct reg_default wm5110_revb_patch[] = { > { 0x80, 0x0 }, > }; > > +static const struct reg_default wm5110_revd_patch[] = { > + { 0x80, 0x3 }, > + { 0x80, 0x3 }, > + { 0x393, 0x27 }, > + { 0x394, 0x27 }, > + { 0x395, 0x27 }, > + { 0x396, 0x27 }, > + { 0x397, 0x27 }, > + { 0x398, 0x26 }, > + { 0x221, 0x90 }, > + { 0x211, 0x8 }, > + { 0x36c, 0x1fb }, > + { 0x26e, 0x64 }, > + { 0x26f, 0xea }, > + { 0x270, 0x1f16 }, > + { 0x51b, 0x1 }, > + { 0x55b, 0x1 }, > + { 0x59b, 0x1 }, > + { 0x4f0, 0x633 }, > + { 0x441, 0xc059 }, > + { 0x209, 0x27 }, > + { 0x80, 0x0 }, > + { 0x80, 0x0 }, > +}; > + > /* We use a function so we can use ARRAY_SIZE() */ > int wm5110_patch(struct arizona *arizona) > { > @@ -235,7 +260,10 @@ int wm5110_patch(struct arizona *arizona) > return regmap_register_patch(arizona->regmap, > wm5110_revb_patch, > ARRAY_SIZE(wm5110_revb_patch)); What happened to rev C? > - > + case 3: Perhaps we should consider #define'ing these? > + return regmap_register_patch(arizona->regmap, > + wm5110_revd_patch, > + ARRAY_SIZE(wm5110_revd_patch)); > default: > return 0; > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
