On 11/19/2013 12:07 PM, Joe Perches wrote:
On Tue, 2013-11-19 at 11:57 -0700, Shuah Khan wrote:
On 11/19/2013 11:53 AM, Joe Perches wrote:
On Tue, 2013-11-19 at 11:46 -0700, Shuah Khan wrote:
Replaced printks with dev_* and pr_* routines. Replacing printk in
__suspend_report_result() will require passing in struct device *
pointer from calling routines and this will require changes to
external interface suspend_report_result() which is used by several
drivers. Hence, this one instance is replaced by pr_err().
[]
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
[]
@@ -1308,9 +1308,8 @@ int dpm_prepare(pm_message_t state)
error = 0;
continue;
}
- printk(KERN_INFO "PM: Device %s not prepared "
- "for power transition: code %d\n",
- dev_name(dev), error);
+ dev_info("PM: not prepared for power transition: ",
+ "code %d\n", error);
Shuah, you have to make sure the files modified by
your patches compile successfully before sending
patches like this.
Oops. I did compile. Missed the warning. Sorry about that.
btw:
When you're doing patches like this, not bugfixes,
not something that's going to be applied to current
or stable, please make them against -next and not
against Linus' tree.
ok. Makes sense changes like this don't need to be rushed. They could
use soak time in linux-next.
Also, I would make the larger change that modifies
all the drivers like I suggested. What you've done
I think is a half-measure and is incomplete.
I was a bit reluctant to change all the drivers since the original
message didn't include device information. However, adding device
information would make this message more useful.
I will re-do the patch to make the larger change.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
[email protected] | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
