On Wed, Nov 20, 2013 at 10:54:57AM -0800, Jacob Pan wrote: > run into a couple of compile issues. > > 1) > include/linux/rcupdate.h: In function ‘rcu_read_unlock_sched_notrace’: > include/linux/rcupdate.h:889:2: error: implicit declaration of function > ‘preempt_enable_no_resched_notrace’ [-Werror=implicit-function-declaration] > > 2) > In file included from drivers/cpufreq/acpi-cpufreq.c:41:0: > include/linux/uaccess.h: In function ‘pagefault_enable’: > include/linux/uaccess.h:34:2: error: implicit declaration of function > ‘preempt_check_resched’ [-Werror=implicit-function-declaration] > > 1) happens when CONFIG_PREEMPT is not set, perhaps add a dummy function?
Ah, indeed, will fix. > 2) I am not sure if we should take pagefault_enable away from modules We can't I think, I'll have to fix that up. Easiest would be to make preempt_check_resched() available again. That function actually adds preemption points so its not bad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
