For readability matters, this patch replaces the hardcoded pci ids by
human readable macros.

Signed-off-by: David Cohen <[email protected]>
---
 drivers/platform/x86/intel_scu_ipc.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/intel_scu_ipc.c 
b/drivers/platform/x86/intel_scu_ipc.c
index 259969d31055..76ca094ed012 100644
--- a/drivers/platform/x86/intel_scu_ipc.c
+++ b/drivers/platform/x86/intel_scu_ipc.c
@@ -62,6 +62,11 @@
 #define IPC_RWBUF_SIZE    20           /* IPC Read buffer Size */
 #define IPC_IOC                  0x100         /* IPC command register IOC bit 
*/
 
+#define PCI_DEVICE_ID_LINCROFT         0x082a
+#define PCI_DEVICE_ID_PENWELL          0x080e
+#define PCI_DEVICE_ID_CLOVERVIEW       0x08ea
+#define PCI_DEVICE_ID_TANGIER          0x11a0
+
 /* intel scu ipc driver data*/
 struct intel_scu_ipc_pdata_t {
        u32 ipc_base;
@@ -637,16 +642,16 @@ static void ipc_remove(struct pci_dev *pdev)
 
 static DEFINE_PCI_DEVICE_TABLE(pci_ids) = {
        {
-               PCI_VDEVICE(INTEL, 0x082a),
+               PCI_VDEVICE(INTEL, PCI_DEVICE_ID_LINCROFT),
                (kernel_ulong_t)&intel_scu_ipc_lincroft_pdata,
        }, {
-               PCI_VDEVICE(INTEL, 0x080e),
+               PCI_VDEVICE(INTEL, PCI_DEVICE_ID_PENWELL),
                (kernel_ulong_t)&intel_scu_ipc_penwell_pdata,
        }, {
-               PCI_VDEVICE(INTEL, 0x08ea),
+               PCI_VDEVICE(INTEL, PCI_DEVICE_ID_CLOVERVIEW),
                (kernel_ulong_t)&intel_scu_ipc_penwell_pdata,
        }, {
-               PCI_VDEVICE(INTEL, 0x11a0),
+               PCI_VDEVICE(INTEL, PCI_DEVICE_ID_TANGIER),
                (kernel_ulong_t)&intel_scu_ipc_tangier_pdata,
        }, {
                0,
-- 
1.8.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to