On Tue, Dec 03, 2013 at 05:10:50PM +0000, David Vrabel wrote: > On 03/12/13 15:40, Julien Grall wrote: > > On ARM (32 bits and 64 bits), the double-word is 8-bytes aligned. This will > > result on different structure from Xen and Linux repositories. > > > > As Linux is using __packed__ attribute, it must have a 4-bytes padding > > before > > each "id" field. > > > > This change breaks guest block support with older kernel. IMHO, it's > > acceptable > > because Xen on ARM is still on Tech Preview and the hypercall ABI is not yet > > freezed. > > > > Only one architecture (x86_32) doesn't have 64-bit ABI for the block > > interface. > > Don't add padding if Linux is compiled for this architecture. > > I'm now satisfied that this is the right thing to do. > > Acked-by: David Vrabel <david.vra...@citrix.com>
Before we go any further, I need testing confirmation that with this patch can still run on x86 hardware the following combinations: 32-bit guest on 64-bit dom0 64-bit guest on 32-bit dom0 and with an 3.12 dom0 B/c I am not seeing that mentioned anywhere and I think that is creating confusion with folks thinking it would break the x86-world (which it shouldn't). > > David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/