> From: [email protected] > [mailto:[email protected]] On Behalf Of Rafael J. Wysocki > Sent: Friday, December 06, 2013 10:01 AM > To: Zheng, Lv > Cc: Andy Shevchenko; Wysocki, Rafael J; [email protected]; LKML > Subject: Re: [PATCH] SFI: fix compilation warnings > > On Friday, December 06, 2013 01:26:07 AM Zheng, Lv wrote: > > > From: Rafael J. Wysocki [mailto:[email protected]] > > > Sent: Friday, December 06, 2013 9:26 AM > > > > > > On Friday, December 06, 2013 01:08:45 AM Zheng, Lv wrote: > > > > > From: Rafael J. Wysocki [mailto:[email protected]] > > > > > Sent: Friday, December 06, 2013 6:37 AM > > > > > > > > > > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > > > > > > When build kernel with make W=1 we get the following compiler error. > > > > > > > > > > > > In file included from drivers/sfi/sfi_acpi.c:66:0: > > > > > > include/linux/sfi_acpi.h: In function ‘acpi_sfi_table_parse’: > > > > > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of > > > > > > function ‘acpi_table_parse’ [-Werror=implicit-function-declaration] > > > > > > if (!acpi_table_parse(signature, handler)) > > > > > > ^ > > > > > > cc1: some warnings being treated as errors > > > > > > > > > > > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > > > > > > > > > > > Signed-off-by: Andy Shevchenko <[email protected]> > > > > > > > > > > OK > > > > > > > > > > Lv, I'm dropping your patch cleaning up the inclusions, please sort > > > > > that thing > > > > > out entirely for the next cycle. > > > > > > > > No, I think Andy's patch is wrong. > > > > > > His patch may be wrong, but the warning in his changelog surely is real. > > > :-) > > > > > > > This warning is existing before merging my fixes. > > > > > > > > Either we fix this warning or leave it as is. > > > > > > > > To fix it, you need to add 1 line in sfi_acpi.h rather than change the > > > > line. > > > > Let me post a fix for this. > > > > > > Please do. And I'm putting all ACPI header cleanups on hold until all > > > warnings > > > of this kind have been fixed by them. Otherwise doing those cleanups > > > makes a > > > little sense in my opinion. > > > > OK, not only this warning, there is another warning in sfi_acpi.c. > > I doubt whether they are strictly tested before upstreamed... > > They are all existing warnings. > > You can apply my new patch before the cleanup series. > > Sorry, I'm already lost in the thick of patches. :-) > > Please resend them all as a single series.
OK, I'll sort them again. Thanks -Lv > > Thanks, > Rafael > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html
