Hi!
> > > The readability of code is also important, IMHO.
> >
> > It did not seem too much better to me.
>
> Well, the beauty is in the eye of the beholder. :-)
>
> Still, it shrinks the code (22 lines vs 37 lines), it uses less GPRs (5 vs
> 7), it uses less
> SIB arithmetics (0 vs 4 times), it uses a well known scheme for copying data
> pages.
> As far as the result is concerned, it is equivalent to the existing code, but
> it's simpler
> (and faster). IMO, simpler code is always easier to understand.
>
>
> > > > If you want cheap way to speed it up, kill cr3 manipulation.
> > >
> > > Sure, but I think it's there for a reason.
> >
> > Reason is "to crash it early if we have wrong pagetables".
> >
> > > > Anyway, this is likely to clash with hugang's work; I'd prefer this not
> > > > to be applied.
> > >
> > > I am aware of that, but you are not going to merge the hugang's patches
> > > soon, are you?
> > > If necessary, I can change the patch to work with his code (hugang, what
> > > do you think?).
> >
> > I think it is just not worth the effort.
>
> Why? It won't take much time. I've spent more time for writing the messages
> in this thread ... ;-)
Well, I know that current code works. It was produced by C compiler,
btw. Now, new code works for you, but it was not in kernel for 4
releases, and... this code is pretty subtle. And it is hand-made, not
C produced.
So... your code may be better but I do not think it is so much better
that I'd like to risk it.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
