(2013/12/09 15:20), Namhyung Kim wrote: > From: Namhyung Kim <[email protected]> > > Currently uprobes don't pass is_return to the argument parser so that > it cannot make use of "$retval" fetch method since it only works for > return probes.
Looks good for me. Reviewed-by: Masami Hiramatsu <[email protected]> > > Cc: Masami Hiramatsu <[email protected]> > Cc: Srikar Dronamraju <[email protected]> > Cc: Oleg Nesterov <[email protected]> > Cc: zhangwei(Jovi) <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]> > Signed-off-by: Namhyung Kim <[email protected]> > --- > kernel/trace/trace_uprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 89dd346865ad..d407a556aa55 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -512,7 +512,7 @@ static int create_trace_uprobe(int argc, char **argv) > > /* Parse fetch argument */ > ret = traceprobe_parse_probe_arg(arg, &tu->tp.size, parg, > - false, false); > + is_return, false); > if (ret) { > pr_info("Parse error at argument[%d]. (%d)\n", i, ret); > goto error; > -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
