On Friday 21 January 2005 2:33 pm, Benjamin LaHaise wrote: > On Fri, Jan 21, 2005 at 06:12:03PM +0000, Alasdair G Kergon wrote: > > Missing cast thought to cause data corruption on devices with stripes > > > ~1TB. > > Why not make chunk a sector_t?
We have to take a mod of the chunk value and the number of stripes (which can be a non-power-of-2, so a shift won't work). It's been my understanding that you couldn't mod a 64-bit value with a 32-bit value in the kernel. Just to be sure, I've changed "chunk" to a sector_t and recompiled, and get the following error: MODPOST *** Warning: "__udivdi3" [drivers/md/dm-mod.ko] undefined! *** Warning: "__umoddi3" [drivers/md/dm-mod.ko] undefined! -- Kevin Corry [EMAIL PROTECTED] http://evms.sourceforge.net/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
