I posted an implementation of library functions for Toeplitz (see [PATCH 1/2] net: Toeplitz library functions). This includes some pre-computation of the table to get reasonable performance in the host. Please take a look.
On the other hand, if you're computing a hash in the host, do you really need Toeplitz, flow_dissector already supports a good hash computation and can parse many more packets than just plain UDP/TCP. We probably only should be doing Toeplitz in the host if we need to match HW computed values. On Thu, Dec 19, 2013 at 11:21 AM, Haiyang Zhang <[email protected]> wrote: > > >> -----Original Message----- >> From: Daniel Borkmann [mailto:[email protected]] >> Sent: Thursday, December 19, 2013 1:45 PM >> To: Haiyang Zhang >> Cc: Ben Hutchings; [email protected]; [email protected]; KY >> Srinivasan; [email protected]; [email protected]; linux- >> [email protected]; [email protected] >> Subject: Re: [PATCH net-next] hyperv: Add support for Virtual Receive Side >> Scaling (vRSS) >> >> On 12/19/2013 07:36 PM, Haiyang Zhang wrote: >> >> > Thank you for the suggestions! I will re-write the send queue >> > selection, enhance the hash calculation, also fix the initialization >> > sequence. >> >> Btw, Toeplitz hash function should either go into lib/hash.c as well or >> include/linux/hash.h to avoid ending up w/ various implementations in >> multiple >> places. > > Will do. > > Thanks, > - Haiyang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
