On 23/12/13 09:59, Joe Perches wrote: > On Mon, 2013-12-23 at 09:46 +0100, Antonio Quartulli wrote: >> On 23/12/13 06:10, Ding Tianhong wrote: >> >> [...] >> >>> --- a/net/batman-adv/originator.c >>> +++ b/net/batman-adv/originator.c >>> @@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, >>> const void *data2) >>> const void *data1 = container_of(node, struct batadv_orig_node, >>> hash_entry); >>> >>> - return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0); >>> + return ether_addr_equal_unaligned(data1, data2) ? 1 : 0; >> >> ether_addr_equal_unaligned() returns a bool value which is implicitly >> converted to 1 or 0: there is no need for the ternary if anymore. > > Should these use batadv_compare_eth? >
That makes sense. I was wondering whether we should get rid of batadv_compare_eth() at all and always use ether_addr_equal_unaligned(). The "unaligned explanation" is part of the name, so there is no need to use a commented helper anymore. However, until that moment it is better to get stuck to batadv_compare_eth(). Ding, can you also follow Joe's suggestion for this patch please? Thanks, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
