于 2013/12/28 14:59, Joe Perches 写道: > On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote: >> Use possibly more efficient ether_addr_equal >> to instead of memcmp. > > This may be a distinction without difference, but > is a CAIF seghead also an ethernet address? >
NO，this is a coincidence, the CAIF seghead is 6 bytes too, So from a logical point of view, maybe a new function with suitable name will be more reasonable here, but the name of ether_addr_equal is not correctly here.:) thanks Regards Ding >> diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c > [] >> @@ -79,7 +79,7 @@ static struct cfpkt *rfm_append(struct cfrfml *rfml, char >> *seghead, > [] >> /* Verify correct header */ >> - if (memcmp(seghead, rfml->seghead, 6) != 0) >> + if (!ether_addr_equal(seghead, rfml->seghead)) > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
