On 2013/12/30 14:05, Joe Perches wrote:
> On Mon, 2013-12-30 at 10:39 +0800, Ding Tianhong wrote:
>> I don't understand packetengine NIC anymore, But I think the change is
>> clearly,
>> as your said, the broadcast check is enough here, did you mean that?
>>
>> !is_broadcast_ether_addr((u8 *)(le32_to_cpu(yp->rx_ring_dma) +
>> entry * sizeof(struct
>> yellowfin_desc)))
>
> Not quite. I meant this could be:
>
> u8 *addr = (u8 *)(unsigned long)le32_to_cpu(yp->rx_ring_dma) +
> entry *
> sizeof(struct yellowfin_desc);
>
> if (!ether_addr_equal(addr, dev->dev_addr) &&
> !is_broadcast_ether_addr(addr)) {
> etc...
>
> but again, I think thus hardly matters and could just as well
> be left alone.
>
>
Ok, I will focus on ether_addr_equal in this patch, anymore will left alone.
Thanks
Regards
Ding
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
