Hi! > --- /dev/null > +++ b/drivers/thermal/clock_cooling.c > @@ -0,0 +1,484 @@ > +/* > + * drivers/thermal/cpu_cooling.c
Bit too much copy&paste... > + * Copyright (C) 2013 Texas Instruments Inc. > + * Contact: Eduardo Valentin <[email protected]> > + * > + * Highly based on cpu_cooling.c. Check english. And you should add samsung & linaro copyright here, since you copied from it. > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ can we get rid of ~~~s? > +static int clock_cooling_get_property(struct clock_cooling_device *ccdev, > + unsigned long input, > + unsigned long *output, > + enum clock_cooling_property property) > +{ > + int i, j; > + unsigned long max_level = 0, level = 0; ... > + if (property == GET_MAXL) { > + *output = (unsigned int)max_level; What is going on with types here? Remove cast? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
