On Tue, Jan 07, 2014 at 11:14:00AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 07, 2014 at 01:47:19PM +0100, Jiri Olsa escreveu: > > The id_hdr_size field was not properly initialized, > > setting it to zero. > > Humm, is there any place where 'machine' doesn't come from calloc/zalloc?
machine__new_host, but I used machine allocated on stack in the tests/dwarf-unwind.c and I thought this was the last member not being initialized.. now I can see vmlinux_maps array does not get initialized as well.. jirka > > - Arnaldo > > > Signed-off-by: Jiri Olsa <[email protected]> > > Cc: Corey Ashford <[email protected]> > > Cc: Frederic Weisbecker <[email protected]> > > Cc: Ingo Molnar <[email protected]> > > Cc: Namhyung Kim <[email protected]> > > Cc: Paul Mackerras <[email protected]> > > Cc: Peter Zijlstra <[email protected]> > > Cc: Arnaldo Carvalho de Melo <[email protected]> > > Cc: David Ahern <[email protected]> > > Cc: Jean Pihet <[email protected]> > > --- > > tools/perf/util/machine.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > > index a98538d..0130279 100644 > > --- a/tools/perf/util/machine.c > > +++ b/tools/perf/util/machine.c > > @@ -27,6 +27,7 @@ int machine__init(struct machine *machine, const char > > *root_dir, pid_t pid) > > machine->pid = pid; > > > > machine->symbol_filter = NULL; > > + machine->id_hdr_size = 0; > > > > machine->root_dir = strdup(root_dir); > > if (machine->root_dir == NULL) > > -- > > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
