On Tue, Jan 14, 2014 at 12:36:06PM +0100, Jean-Francois Moine wrote: > This patch > - removes the fields of the platform data which are of no use to the > non-DT platform callers, > - uses a new private structure to handle all the sound card information, > - simplifies the code and make easier a possible multi-DAI links extension. > > Signed-off-by: Jean-Francois Moine <[email protected]> > --- > Xiubo, I also removed 'of_device_is_available' which seems really > useless: the module is not probed when the DT status is not "okay".
Please send this as a patch series to aid review, one patch doing four different changes is much harder to review. > ret = asoc_simple_card_sub_parse_of(np, > - &info->cpu_dai, > - of_cpu); > + &priv->cpu_dai, > + (struct device_node **) > + &dai_link->cpu_of_node, > + &dai_link->cpu_dai_name); What's this cast here for? That code doesn't look at all safe.
signature.asc
Description: Digital signature
