On Tue, Jan 14, K. Y. Srinivasan wrote:
This function should return valid numbers:
> +static ssize_t fcopy_write(struct file *file, const char __user *buf,
> + size_t count, loff_t *ppos)
> +{
> + int error = 0;
> +
> + if (count != sizeof(int))
> + return 0;
Should be an error.
> +
> + if (copy_from_user(&error, buf, sizeof(int)))
> + return -EFAULT;
> +
> + if (in_hand_shake) {
> + fcopy_handle_handshake();
> + return 0;
Should be sizeof(int).
> + }
> +
> + /*
> + * Complete the transaction by forwarding the result
> + * to the host. But first, cancel the timeout.
> + */
> + if (cancel_delayed_work_sync(&fcopy_work))
> + fcopy_respond_to_host(error);
> +
> + return sizeof(int);
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
