> -----Original Message----- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, January 13, 2014 6:43 PM > To: Ren, Qiaowei > Cc: H. Peter Anvin; Thomas Gleixner; Ingo Molnar; x...@kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH 5/5] x86, mpx: extend siginfo structure to include bound > violation information > > On Mon, Jan 13, 2014 at 04:22:27PM +0800, Ren Qiaowei wrote: > > >I tried to use generic structure and macro, but many members of > > >generic struct insn are not used for MPX, > > I think that's ok - there are a lot of examples in the kernel where only a > subset > of the struct members are used by a particular functionality. > > > Because only struct insn_field and several macros may be replaced with > > generic version, I guess it maybe be confused easily to include > > generic insn header. What do you think about it? > > Yes, I think the idea is to use and, if needed, extend the generic > functionality > instead of growing our own here and there for obvious benefits. > Yes, I once tried to use and extend the generic functionality to implement the decoding, but I noticed it didn't work out well for this specific MPX case. Anyway, I will try to use generic version more.
Thanks, Qiaowei
