OK, it seems as a left over from an earlier code reworks but 22933152934f3 doesn't seem to contain any code following that if-else so maybe review driven changes.
On Mon 20-01-14 13:22:03, Vladimir Davydov wrote: > Signed-off-by: Vladimir Davydov <[email protected]> Reviewed-by: Michal Hocko <[email protected]> > --- > mm/memcontrol.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 7f1a356..7f1511d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3311,11 +3311,9 @@ static void kmem_cache_destroy_work_func(struct > work_struct *w) > * So if we aren't down to zero, we'll just schedule a worker and try > * again > */ > - if (atomic_read(&cachep->memcg_params->nr_pages) != 0) { > + if (atomic_read(&cachep->memcg_params->nr_pages) != 0) > kmem_cache_shrink(cachep); > - if (atomic_read(&cachep->memcg_params->nr_pages) == 0) > - return; > - } else > + else > kmem_cache_destroy(cachep); > } > > -- > 1.7.10.4 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to [email protected]. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"[email protected]";> [email protected] </a> -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
