On 01/22/2014 02:22 AM, David Rientjes wrote: > On Fri, 17 Jan 2014, Vladimir Davydov wrote: > >> The name `max_pass' is misleading, because this variable actually keeps >> the estimate number of freeable objects, not the maximal number of >> objects we can scan in this pass, which can be twice that. Rename it to >> reflect its actual meaning. >> >> Signed-off-by: Vladimir Davydov <[email protected]> >> Cc: Andrew Morton <[email protected]> >> Cc: Mel Gorman <[email protected]> >> Cc: Michal Hocko <[email protected]> >> Cc: Johannes Weiner <[email protected]> >> Cc: Rik van Riel <[email protected]> >> Cc: Dave Chinner <[email protected]> >> Cc: Glauber Costa <[email protected]> > This doesn't compile on linux-next: > > mm/vmscan.c: In function ‘shrink_slab_node’: > mm/vmscan.c:300:23: error: ‘max_pass’ undeclared (first use in this function) > mm/vmscan.c:300:23: note: each undeclared identifier is reported only once > for each function it appears in > > because of b01fa2357bca ("mm: vmscan: shrink all slab objects if tight on > memory") from an author with a name remarkably similar to yours.
Oh, sorry. I thought it hadn't been committed there yet. > Could you rebase this series on top of your previous work that is already in > -mm? Sure. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
