On Thu, Jan 23, 2014 at 08:51:47PM +0100, Fabian Frederick wrote: > mutex_destroy added on each device in block2mtd_exit and add_device failure > > Signed-off-by: Fabian Frederick <[email protected]> > --- > drivers/mtd/devices/block2mtd.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c > index 0efee5b..8071596 100644 > --- a/drivers/mtd/devices/block2mtd.c > +++ b/drivers/mtd/devices/block2mtd.c > @@ -240,14 +240,14 @@ static struct block2mtd_dev *add_device(char *devname, > int erase_size) > > if (IS_ERR(bdev)) { > pr_err("error: cannot open device %s\n", devname); > - goto devinit_err; > + goto devinit_err1;
Ah, this one commit looks good, but the naming of the labels doesn't. Instead, you should use a name describing what the error path does, such as "err_free_block2mtd" and "err_destroy_mutex" or something like that. We have a language full of words with meaning, so it's shame to use dumb numbers :-) -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
