Linus Torvalds <[email protected]> wrote: > > - p = proc_create("cells", 0, proc_afs, &afs_proc_cells_fops); > > + p = proc_create("cells", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, > > &afs_proc_cells_fops); > > - p = proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops); > > + p = proc_create("rootcell", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, > > &afs_proc_rootcell_fops); > > So the S_IFREG isn't necessary.
True. Is it worth creating proc_create_special() that can create a non-regular file and then making proc_create() only permit regular files (and complain if the S_IFMT field is not zero)? > And quite frankly, I personally think S_IRUGO | S_IWUSR is _less_ > readable than 0644. It's damn hard to parse those random letter > combinations, and at least I have to really think about it, in a way > that the octal representation does *not* make me go "I have to think > about that". Fine by me. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
