Hi, On Thursday 30 January 2014 05:22 PM, Pratyush Anand wrote: > On Thu, Jan 30, 2014 at 07:43:37PM +0800, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 30 January 2014 04:18 PM, Mohit Kumar wrote: >>> From: Pratyush Anand <[email protected]> >>> >>> PCIe RC drivers are initialized with subsys_initcall. Few PCIe drivers >>> like SPEAr13xx needs phy drivers to be initialized. >> >> Instead change PCIe RC drivers to module init. Phy drivers should be loaded >> very early otherwise. (Hint: drivers/Makefile). > > I think PCIe RC driver can not be made module init. Bjorn can comment > better.
Why not? I have used it for DRA7xx without any issues (I'll send that one upstream once the PIPE3 phy part gets clear). > > All PCIe card drivers are initialized with module init. RC driver must > have been initialized before any card driver initialization. > Currently, card drivers does not have deferred probe concept, so I am > not sure if keeping RC driver as module init will work always. the card drivers will anyway be probed only after RC driver comes up no? > > By the way, is there any side effect of loading phy driver very early? I assume you meant 'is there any side effect of using subsys_initcall?', since phy driver is loaded early anyway. The answer is no just that module_init is common one and more people prefer to use module_init. (btw initial versions of phy-core had susbsys_initcall before it got changed to use module_init) Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
