On Thu, Jan 20, 2005 at 09:19:17AM -0500, Ed L Cashin wrote: > Bodo Eggert <[EMAIL PROTECTED]> writes: > > > Ed L Cashin <[EMAIL PROTECTED]> wrote: > > > >> +if?test?-z?"$conf";?then > >> +????????conf="`find?/etc?-type?f?-name?udev.conf?2>?/dev/null`" > >> +fi > >> +if?test?-z?"$conf"?||?test?!?-r?$conf;?then > >> +????????echo?"$me?Error:?could?not?find?readable?udev.conf?in?/etc"?1>&2 > >> +????????exit?1 > >> +fi > > > > This will fail and print > > --- > > bash: test: etc/udev.conf: binary operator expected > > --- > > if there is more than one udev.conf. > > > > Fix: Always put quotes around variables. > > Thanks. With the changes below, it still will complain if it finds > more than one udev.conf, but only if /etc/udev/udev.conf doesn't > exist. > > > Quote all shell variables, and use /etc/udev/udev.conf if available. > > Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]>
Applied, thanks. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
