Alexander Shishkin <alexander.shish...@linux.intel.com> writes:
> +
> +static void pt_trace_core_output(struct coredump_params *cprm,
> +                              struct perf_event *event,
> +                              unsigned long len)
> +{
> +     struct pt_buffer *buf;
> +     u64 from, to;
> +     int ret;
> +
> +     buf = itrace_priv(event);
> +
> +     if (!dump_emit(cprm, pt_pmu.capstr, pt_pmu.caplen))
> +             return;

It would be nicer if this was a separate note, instead of just being
concatenated with the rest of the data.

Would make simpler parsing and be cleaner.

-Andi

-- 
a...@linux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to